Added invalid point checking to RGBD and Depth Camera plugins to set is_dense flag accordingly (backport #575)#579
Merged
ahcorde merged 1 commit intogz-sensors9from Jan 7, 2026
Conversation
Merged
9 tasks
ahcorde
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #574
Summary
Fix similar to #180. Added
gz::math::isnanandstd::isinfchecks to depth/coordinates in allFillMsgmethods in PointUtil.cc, which RGBD Camera and Depth Camera depend on.
Reproducibility steps described in #574.
New output should look the same, except for the
is_denseflag, which should be set to false.(maybe another test/world should be done where the point cloud only contains valid points, to check if
is_denseis correctly set to true)Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.This is an automatic backport of pull request #575 done by Mergify.